Skip to content

fix(dapp): count cash-outs in the admin overview's volume-by-type chart #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Depo-dev merged 1 commit into from
Oct 28, 2026
Merged

fix(dapp): count cash-outs in the admin overview's volume-by-type chart #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/dapp/app/admin/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ import { DonutChart, OutcomeBars, RankedBars, TrendChart } from '../../component
import { EmptyNote, Kpi, PageTitle, Panel, WithStats } from '../../components/admin/parts'
import { formatCount, formatPercent, formatUsd, kindLabel } from '../../components/admin/stats'

/** The types the headline volume adds up, so the donut and the total agree. */
const COUNTED = ['swap', 'plan', 'offer', 'send']
/**
* The types the headline volume adds up, so the donut and the total agree.
* Mirrors HEADLINE_KINDS in admin-metrics.ts — out of sync once already,
* when offramp was added there and not here: the total counted cash-outs,
* the donut silently dropped them, and a period that was 97% cash-outs by
* dollar value read as "100% Swaps".
*/
const COUNTED = ['swap', 'plan', 'offer', 'send', 'offramp']

export default function AdminOverviewPage(): JSX.Element {
return (
Expand All @@ -26,7 +32,7 @@ export default function AdminOverviewPage(): JSX.Element {
note={
overview.unvalued > 0
? `${formatCount(overview.unvalued)} transactions had no price`
: 'Swaps, limit and standing orders, sends'
: 'Swaps, limit and standing orders, sends, cash-outs'
}
/>
<Kpi
Expand Down
Loading