Repository navigation
Description
Problem
admin-ui is built and checked with pnpm 9 (CI, Nix, mise) while Dependabot runs pnpm 12.x (Installed version of pnpm: 12.10.1, Dependabot job of run 43935320583). pnpm 12 ignores pnpm.overrides in package.json (it reads them only from pnpm-workspace.yaml), so the Dependabot lockfile of #135 was written without the overrides: block and pnpm 9 rejected it on develop (ERR_PNPM_LOCKFILE_CONFIG_MISMATCH).
PR #134 works around it by declaring the same overrides in both admin-ui/package.json and admin-ui/pnpm-workspace.yaml, plus a jq/yq guard step in admin-ui.yml that fails on drift. That is a workaround, not a fix: two copies to maintain and a CI step to police them.
Constraint found: the pinned nixpkgs has no pnpm >= 10
default.nix pins nixpkgs 8b27c1239e5c421a2bbc2c65d52e4a6fbf2ff296. Evaluating it:
| attribute | result |
|---|---|
pnpm_9 / pnpm |
9.12.3 |
pnpm_10, pnpm_11, pnpm_12 |
do not exist (the error suggests only pnpm_8 or pnpm_9) |
So the Nix build cannot move to pnpm 10+ without bumping the nixpkgs pin (or packaging pnpm another way), which also changes fetchDeps/configHook and the admin-ui.pnpm.* hashes. Decide this first.
Where pnpm 9 is pinned
mise.toml:10:"npm:pnpm" = "9"(documented inadmin-ui/DEV_GUIDE.md).github/workflows/admin-ui.yml:pnpm/action-setupversion: 9at lines 29, 64, 86 and 125nix/admin-ui.nix:pkgs.pnpm_9.fetchDeps(line 57),pkgs.pnpm_9andpkgs.pnpm_9.configHook(lines 106-107), and the pnpm 9.12.3 sandbox workaround that patchespnpm.cjsto re-create the lostoverrides:block (comment starting at line 20)admin-ui/package.json: nopackageManagerfield, so nothing tells Dependabot or contributors which pnpm to use.pre-commit-config.yaml:114: theadmin-ui-lockfilehook runs whateverpnpmis on the PATH- Docs:
AGENTS.mdandnix/expected-hashes/README.md(pnpm hash instructions)
Acceptance criteria
- One pnpm major (10 or newer) is used by CI, mise, pre-commit and Nix, and is declared in
package.jsonpackageManager. - The overrides exist only in
admin-ui/pnpm-workspace.yaml;package.jsonpnpm.overridesand the "pnpm overrides match" step ofadmin-ui.ymlare deleted. - The nixpkgs pin provides that pnpm (bump
default.nixif needed) and the sandbox workaround innix/admin-ui.nixis removed or shown to be still required. -
admin-ui/pnpm-lock.yamland all threenix/expected-hashes/admin-ui.pnpm.*.sha256files are regenerated, each from a build on its own platform. -
pnpm install --frozen-lockfilepasses in the Admin UI workflow, innix-build -A admin-uiand in the pre-commit hook. - The next Dependabot PR on
/admin-uikeeps theoverrides:block in its lockfile and passes CI without a manual fix.
Related
- PR feat!: serve Vault client routes only under /v1/auth and add userpass login #134 (dual overrides, guard, lockfile and Nix hash fixes) and Dependabot PR fix: bump the admin-ui-minor-patch group across 1 directory with 2 updates #135.
- The
minimatchoverride added in feat!: serve Vault client routes only under /v1/auth and add userpass login #134 can go onceeslint>= 10.15.0 and@typescript-eslint/typescript-estree>= 8.73.0 (both acceptminimatch ^11) are in the lockfile.
Activity