Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build libheif 1.23.4 into Cosmos-scoped libvips packages for Sharp 0.35.4. This provides patched native image parsing for Lambda Linux x64 and cosmos-www Alpine ARM64, plus Alpine x64 CI and Apple Silicon development.
The fork builds and tests artifacts only. The private cosmos-actions publisher will verify the successful run and exact commit before publishing to Nexus; public forks receive no Nexus credentials. Existing HEVC codec support is unchanged.
How It Was Found
ENG-14549 tracks the libheif security remediation: https://linear.app/cosmos/issue/ENG-14549. Released npm native packages lag the patched libheif source.
How It Was Tested
Local Node and Bash syntax checks, actionlint, and git diff checks passed. CI builds each native target and tests upstream Sharp loading, native dependency versions, JPEG/PNG/WebP/AVIF decoding, resize and malformed-input rejection in representative runtime containers. Native builds intentionally run in CI.
No deployment or feature-flag change in this PR. Consumers will pin verified Nexus artifacts in ENG-14550 and ENG-14551, followed by dev/prod rollout verification.