Repository navigation
5.8dev - #155
Merged
Merged
5.8dev#155
Conversation
SimJoyStick.cpp is `#if _WIN32 || _WIN64 ... #elif __linux__ ... #endif` with no `#else`. On macOS neither branch is taken, so `SimJoyStick::impl` is never defined -- while the constructor below the #endif still does `new impl()`. That is five compile errors, ending in sizeof applied to an incomplete type inside unique_ptr, and it stops the AirSim plugin building for Unreal on macOS. A no-op backend rather than an #error: there is genuinely no joystick support on this platform, and the caller's contract already covers that case. Every consumer checks `state.is_initialized`, so reporting false makes a simulator behave as though no stick is plugged in -- which is true -- instead of pretending one is present and reporting centred axes forever. With this, the AirSim plugin builds against Unreal Engine 5.8 on Apple Silicon with zero errors (Xcode 26.1.1, macOS 15.7.7), and a SimpleFlight multirotor arms, takes off and flies to a commanded waypoint under physics.
SimJoyStick: a no-op backend for platforms with no joystick support (fixes the macOS plugin build)
…upport (fixes the macOS plugin build)"
…stub Revert "SimJoyStick: a no-op backend for platforms with no joystick support (fixes the macOS plugin build)"
MacOS fixes
Fixed ROS2 node publishing the same duplicate messages
The server binds six parameters and the client sent five, so every call failed on arity. The Python client already passes all six.
Fix simSpawnObject argument count in the C++ client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.