Skip to content

Fix Euler rotation matrix angles and composition order - #173

Open
LuuSir wants to merge 1 commit into
Cosys-Lab:5.2.1from
LuuSir:codex/fix-euler-rotation
Open

LuuSir wants to merge 1 commit into
Cosys-Lab:5.2.1from
LuuSir:codex/fix-euler-rotation

Conversation

@LuuSir

@LuuSir LuuSir commented Oct 5, 2026

Copy link
Copy Markdown

Base: Cosys-Lab/Cosys-AirSim:5.2.1 (09d8f992).

euler_to_rotation_matrix(0, 0, pi/2) currently rotates the x axis by 45 degrees. Use full angles in matrix entries and compose rotations as Rz(yaw) @ Ry(pitch) @ Rx(roll) to match euler_to_quaternion. Preserve the existing list return type and apply_rotation_offset(position, pitch, yaw, roll) argument order.

Validation

  • Three unittest methods pass on the independent upstream patch: axis quarter turns, quaternion agreement for combined angles, and offset argument order.
  • The same suite reports six failed assertions/subtests on the unmodified upstream implementation.
  • No simulator required. From the repository root, set PYTHONPATH=PythonClient and run python -m unittest discover -s PythonClient/tests -p test_rotation_utils.py -v.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 07:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants