Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
Cosys-Lab/Cosys-AirSim:5.2.1(09d8f992).A spawned component can initially be registered using
GetUniqueID(), then later be renamed by the identifier generator using its render proxy's persistent index. During runtime validation, registration usedCube_0_MergeAuditCube_39097, while deletion looked forCube_0_MergeAuditCube_438. This leaves stale entries and prevents cleanup.Use the UObject ID consistently for the component lifetime. During deletion, resolve the original registered name by component pointer, evaluate
DeleteComponentin all build configurations, remove the component's color/value/texture entries, and list live components from the component registry.destroyObjectunregisters the actor and refreshes annotation camera lists before destruction. This complements the spawn registration already integrated from PR #153.Validation
PythonClient/tests/smoke_annotation_lifecycle.py --port <disposable simulator port>performs two spawn/render/update/destroy cycles using existing upstream APIs. Requires a level with a Cube asset.The ID suffix now uses UObject identity and remains unique for live components; identifiers remain session-specific.