fix(submission): scribing canvas render order and unrecorded Voice teardown - #8542
Merged
adi-herwana-nus merged 2 commits intoAug 12, 2026
Merged
Conversation
Fabric.js re-parents the raw <canvas> node into its own container div, so a sibling rendered before it would need React to `insertBefore` relative to a node that is no longer a direct child — which throws on every toggle, e.g. a redundant re-initialize resetting `isCanvasLoaded`. Appending a trailing sibling never needs a reference node.
`stopRecord()` rejects with "Recorder has already stopped", and nothing awaits it — so it becomes an unhandled rejection, surfacing as a full-page crash under StrictMode's dev-only double mount/unmount on every unrecorded Voice question.
adi-herwana-nus
deleted the
lws49/fix-submission-page-edge-cases-rebased
branch
August 12, 2026 04:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are taken from rebasing #8531 on top of latest master.
I reverted the empty
.catch()block change (recorder.js), it's not good practice to silently ignore errors without surfacing to the user, we will take a closer look and implement properly when we decide to refactor/revamp Voice Response component.