Skip to content

Restore historical checks after the CI documentation update #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mister-Meeseeks merged 1 commit into from
Oct 20, 2026
Merged

Restore historical checks after the CI documentation update #3648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/replay_historical_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,10 @@
'path': 'docs/ci-verification.md',
'input': 'ledger-frontier741-ci-verification.md',
'sha256': 'a854022e0e1d5d4db4d60e586be3ea56005013ef14a1fc06d02bc06e8529c4b0',
'accepted_live_sha256': ['ae5bcac684ce2188632f38dee8ed46ebdc9588f490401505aa1cac33c55d84db']},
'accepted_live_sha256': [
'ae5bcac684ce2188632f38dee8ed46ebdc9588f490401505aa1cac33c55d84db',
# Tekalign's PR3139 appends deadline usage; replay still restores PR695 bytes.
'a3711fe12d560fac7726c530b9c8c622182f3d4f231a876c163616e49bd911bc']},
{'manifest': 'research/community-frontier890-audit/CONTENT-COVERAGE.json',
'field': ['pull_requests', '853', 'files'],
'path': 'scripts/verify_complex741_parallel.py',
Expand Down
51 changes: 51 additions & 0 deletions tests/test_historical_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,57 @@ def test_live_guards_also_admit_the_actual_committed_source_bytes(self):
digest = hashlib.sha256(raw).hexdigest()
self.assertIn(digest, [entry['sha256'], *entry['accepted_live_sha256']])

def test_ci_document_successor_replays_exact_frozen_bytes(self):
config = next(entry for entry in checker.CONFIG['tooling-ledger']['additional_inputs']
if entry['path'] == 'docs/ci-verification.md')
live_bytes = (ROOT / config['path']).read_bytes()
frozen_bytes = (checker.INPUTS / config['input']).read_bytes()
manifest_bytes = (ROOT / config['manifest']).read_bytes()
self.assertNotEqual(live_bytes, frozen_bytes)
with tempfile.TemporaryDirectory() as td:
root, inputs = Path(td) / 'source', Path(td) / 'inputs'
inputs.mkdir()
frozen = inputs / config['input']
frozen.write_bytes(frozen_bytes)
paths = [config['path'], config['manifest']]
for name, data in zip(paths, (live_bytes, manifest_bytes)):
destination = root / name
destination.parent.mkdir(parents=True, exist_ok=True)
destination.write_bytes(data)
target = Path(td) / 'snapshot'
expected = checker.materialize(root, target, config, paths, inputs)
self.assertEqual((target / config['path']).read_bytes(), frozen_bytes)
self.assertEqual(expected[config['path']], config['sha256'])
self.assertEqual((target / config['manifest']).read_bytes(), manifest_bytes)
self.assertEqual((root / config['path']).read_bytes(), live_bytes)
checker.verify_unchanged(target, expected)

# An append must not be admitted merely because its prefix is known.
(root / config['path']).write_bytes(live_bytes + b'\n')
with self.assertRaisesRegex(ValueError, 'Unrecognized live source update'):
checker.authenticated_input(root, config, inputs)
(root / config['path']).write_bytes(live_bytes)
frozen.write_bytes(frozen_bytes + b'\n')
with self.assertRaisesRegex(ValueError, 'Changed historical input'):
checker.authenticated_input(root, config, inputs)
frozen.write_bytes(frozen_bytes)

altered = json.loads(manifest_bytes)
records = altered
for field in config['field']:
records = records[field]
self.assertIsInstance(records, list)
for record in records:
if record.get('integrated_path') == config['path']:
record['integrated_sha256'] = '0' * 64
(root / config['manifest']).write_text(json.dumps(altered), encoding='utf-8')
with self.assertRaisesRegex(ValueError, 'Missing or changed predecessor source pin'):
checker.authenticated_input(root, config, inputs)

self.assertEqual((ROOT / config['path']).read_bytes(), live_bytes)
self.assertEqual((ROOT / config['manifest']).read_bytes(), manifest_bytes)
self.assertEqual((checker.INPUTS / config['input']).read_bytes(), frozen_bytes)

def test_real_snapshots_match_unchanged_predecessor_pins(self):
for name, config in checker.CONFIG.items():
with self.subTest(package=name):
Expand Down