Repository navigation
Prove variable-gap precision and linear storage for cyclic band solves - #5284
Merged
Mister-Meeseeks merged 2 commits intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves and implements a fixed-point direct solver for every real dyadic cyclic band matrix with positive diagonal and row-dominance gap delta>0. The gap may shrink with size. The required fractional guards are logarithmic in matrix size and inverse gap. This extends the constant-smallness periodic interface and the fixed385-row direct consumer to a quantified input contract. It does not change the complete kappa calculation or the selected frontier.
All-size proof, exact evidence, integer solver, and source pins.
Natural-order cyclic fill uses at most 4NW^2 factor products and at most (4W+1)N retained factor entries. Each complex RHS solve uses at most 8NW products and 4N component roundings/divisions. Products and Schur sums are exact integers; each factor entry is rounded once. The proof supplies an explicit factor residual, both triangular solve errors, and a uniform integer range for all allowed inputs. These are arithmetic counts, not a complete native or physical-tape tariff.
For the 4,097-row width-four fixture with gap 1/4096, 60 fractional bits suffice for the 2^-20 solution target. The proved signed width is 151 bits; the observed peak is 132. Factor preparation uses 261,836 products and each complex solve uses 130,960 products. Exact original-matrix residuals certify the target. This finite fixture corroborates the written all-size theorem; it is not a Gaussian production-family claim.
The nearest predecessor is Dugongue's PR #4554, specifically its constant-gap ordinary-band proof and periodic Woodbury reduction. Ryanson Jonathan's independent check retains that scope. The earlier batched principal-window note uses noncyclic factors. PR #5260 proves the fixed385-row consumer, with a matrix-specific certificate. The present result adds direct cyclic fill, one-round factor residuals and explicit variable-gap precision. Classical diagonal dominance, Wilkinson's error analysis and Higham's exposition retain their credit. No new general stability theorem or global literature priority is claimed.
Base: canonical main ff3cc58, priority revision7. Every declared source pin is an ancestor of this publication. Predecessor code is not imported or edited. Source identities retain the OpenAI/math and Harvey–van der Hoeven lineage documented in the source notice. Prepared by Ali Romman with substantial OpenAI Codex assistance; Apache-2.0.
With CPython 3.12 and the standard library:
Expected:
PASS_CYCLIC_BAND_GAPin normal and optimized modes, followed byPASS_REGISTERED_RESEARCH_PACKAGE.Both registered modes pass. A separately written pivoted rational solver checks 72 complex right-hand sides on 36 small cases and nine matrix/RHS scale pairs. The replay also checks 129 symbolic cyclic patterns, eight controls and exact residuals at 257, 1,025 and 4,097 rows. Four source mutations fail in both modes before receipt checks: omitted wrap entries, wrong update sign, wrong divisor and omitted row-gap validation. Source pins and committed bytes pass. Both read-only Git-free export replays pass; all nine files remain unchanged. Canonical main and scoped overlap were refreshed. Hosted CI passed both planning and the focused replay at this exact head.
Limitations: the matrix must meet the stated real dyadic contract. Matrix formation, source approximation, final output-grid rounding, physical movement, native relations and the outer invoice remain caller obligations. The full-history wrapper was not run in the shallow checkout; direct source ancestry passed. No selected cold replay, Lean, Docker, independent human review or proof-kernel acceptance is claimed.