Repository navigation
Fix Git-spelling tests under legacy console encodings - #5460
Merged
Mister-Meeseeks merged 1 commit intoOct 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On native Windows with redirected CP1252 output, the exact Git-spelling test fails even though the planner correctly rejects the Unicode alias: its child escapes the combining accent while the test expects a literal character. Match the fixture child's output encoding to its capture decoder, and add ASCII/CP1252/UTF-8 controls for inherited settings and explicit diagnostic output.
This integrates Arham Tahir's already published correction, credited in the test and evidence note. His original diagnosis, patch and receipts remained unapplied to current main; #5358 subsequently recorded the same limitation. Nick Petalas's #3007 supplies the original exact-path guard and tests.
Only the test module and its evidence note change. Rejections still require exit 1, the correctly rendered offending path, empty stdout and unchanged prior GitHub-output bytes. Correcting the declaration selects the expected consumer for the same Git change. Production validation, frozen packages, source pins and the selected frontier are unchanged. No new kappa or mathematical acceptance is claimed.
Validation at contribution head
771dae262537e01801af38b4170b8bcf3dfdea5a:research/replay-input-head-spellingregistered replay passes on both platforms: historical three-omission/three-rejection/two-positive comparison, all ten spelling tests, and all five lexical-input tests.git diff --checkpass.Reproduce with Python 3.12 and Git:
The registered comparison requires historical source commit
836b19bfa309ceafbc8ee32a15e8c4b10dde7e11; it was explicitly fetched locally. The selected metadata baseline passes. Full selected cold replay, Windows descendant containment, other Python versions and independent human/formal acceptance were not checked. Hosted CI is separate from local evidence.Started from and refreshed against canonical main
32890bc5de034ab8fc93ac88ead7279a6a416d04, priority 7. Canonical claim and handoff. Final overlap covered 330 open PRs, 4,725 Discussion records and all 7,402 tracked in-scope notes, with reported complete coverage; this is not a novelty guarantee.Prepared for Mihir Srivastava with substantial OpenAI Codex assistance; Apache-2.0. Predecessor attribution is retained.