Repository navigation
Add opt-in Windows stream ownership for Git blob reads - #5463
Open
mihir-s-05 wants to merge 1 commit into
Open
mihir-s-05 wants to merge 1 commit into
mihir-s-05 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Windows Git blob reader can stay blocked after its response watchdog fires when an exited leader's descendant retains the pipe. This adds an opt-in streaming Job Object adapter, composed with the authenticated, unchanged reader from current main. In that composition, deadline and return paths stop the descendants while preserving exact binary reads, legacy fallback and consumer pauses.
This is a source-pinned implementation experiment for review. The shared production runner and selected frontier are unchanged. Production adoption remains an explicit next task.
Package, scope and reproduction · canonical claim and handoff
The adapter exposes the Popen subset used by the actual reader, reusing ywz65's isolated event gate and Job Object protocol from #2469. It assigns ownership before releasing the requested command, keeps the real stdin/stdout handles, makes watchdog kill terminate the job, and closes the job on context exit. Native structures and the gate are credited derivatives, not a newly claimed ownership mechanism.
Validation at contribution head
991da9010925914ec64a5293286edb10a7910218:PASS_PORTABLE_CONTROLS_WINDOWS_NOT_RUN.--require-windowsrejects reduced coverage. A disposable source-byte mutation rejects before fixture launch.Normal receipt · optimized receipt · portable receipt
Limits: controlled Python producers reproduce the process/pipe boundary; no naturally stalled installed-Git incident is claimed. Other Windows/Python environments, restrictive enclosing-job policies, owner death during setup, general Popen compatibility and spawn-error diagnostic equivalence remain untested. The selected cold replay and full-history provenance preflight were not run. Hosted CI and independent review remain separate from these local receipts.
Started and refreshed against canonical main
32890bc5de034ab8fc93ac88ead7279a6a416d04, priority revision 7. Final overlap covered 332 open PRs, 4,732 Discussion records and all 7,402 tracked in-scope notes, with complete reported pagination/inventory. The two concurrent baseline-audit claims surfaced during refresh; this contribution released that duplicate scope and supplies the complementary adapter. #5461 and the published probe at7a9a2b67e1967ba31b7330031daae186d6b87a86retain their diagnosis credit.Credit ywz65 (#2469/#2452), Brian / JoyboyBrian (#4738/#5185), Nick Petalas (#2752), Mihir Srivastava's Windows successors, Douglas Colkitt, Paul Romeo, yssite, Arham Tahir, Woklerx, Tekalign and the retained source lineage. Prepared for Mihir Srivastava with substantial OpenAI Codex assistance, one agent; Apache-2.0, license and notices included. No new kappa or mathematical acceptance is claimed.