Repository navigation
Speed rational-rank certificate generation with primitive integer pivots - #6705
Open
josecarlosgonzalezroque-design wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change and mathematical scope
The exact rational-rank certificate producer still used Fraction arithmetic for every forward-elimination entry after #6272 accelerated verification products. Use denominator-cleared primitive integer rows for pivot discovery, preserving the first-pivot policy and complete serialized certificate. This is verifier engineering; no new kappa or selected-frontier change.
On the unchanged #6272 48-by-64 rank-eight fixture, seven alternating fresh-process generate/save/check pairs reduce median local wall time from 727.3981 ms to 673.6825 ms (7.38%). All seven paired after times are lower; all 32 CLI commands, including warmups, pass with identical certificate bytes. This is one Windows/CPython workload, not an all-input or supplier speed claim.
Task and overlap
Started from and refreshed against canonical main
7c49fe32c55de02c2c873655c804b16e4c3fef0a, priority revision 8, cardreplay-runtime, scope keyb1dd41940c60d240b47a(refined scope). Checked live handoffs/Discussions and targeted all-state PR-body overlap. Local sparse-note/cache coverage is incomplete and explicitly recorded. #5789 supplies the interface; #6272 changes the product checker, while this change accelerates pivot discovery.The review note records the proof, exact sources, overlap limits and open questions.
Validation
-I -O -W error, including 154 new exact pivot/full-certificate comparisons against the Fraction policy. Existing independent minor-enumeration and damaged-certificate/input-byte controls remain.git diff --checkpass.ca8b340c747b1b5dd752cd76a8e562b1e7f73687exactly matches the staged local tree.Environment: Windows 11 build 26300, CPython 3.12.10, 16 logical CPUs. No full supplier replay, complete multiplication proof, independent human review, or hosted CI success is claimed.
Credit
Credit Ali Romman's #5789 interface, Nick Petalas's #6272 product optimization and benchmark fixture, and classical exact elimination. Prepared for josecarlosgonzalezroque-design with substantial OpenAI Codex assistance, one agent; Apache-2.0. Frozen packages and the selected frontier are unchanged.
Open next questions
Measure a named consumer's source-bound matrices before making a production-throughput claim. Separately compare high-rank matrices with unrelated denominators to assess peak memory and runtime; the present measurement establishes neither a worst-case bound nor a fixed-memory backend contract.