Repository navigation
Conversation
…tree Add narrow pnpm overrides. The Crossmint/Dynamic wallet SDK packages pin these exact versions and no newer parent version fixes them: - ws@>=8.0.0 <8.21.0: 8.18.0/8.18.1/8.18.2 -> 8.21.0 (GHSA-96hv-2xvq-fx4p, GHSA-58qx-3vcg-4xpx) - @metamask/sdk@0.33.0 -> 0.33.1, pulls sdk-communication-layer 0.33.1 (GHSA-qj3p-xc97-xw74) - @dynamic-labs/iconic>sharp: 0.33.5 -> 0.35.4 (GHSA-f88m-g3jw-g9cj, GHSA-rgj7-g3m4-5g8c) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot reports vulnerabilities in
ws,@metamask/sdkandsharp. All three come from the wallet SDK tree:@crossmint/client-sdk-react-ui@4.9.0->@dynamic-labs/*@4.28.0->viem/@metamask/sdk/@dynamic-labs/iconic.These parents pin exact versions.
@crossmint/client-sdk-react-ui@4.9.0is the latest version and it pins@dynamic-labs/*@4.28.0. Thus a parent bump is not possible. This PR adds three narrowpnpm.overrides.Changes
viem,isows)@dynamic-labs/ethereum)debug@4.4.2)@metamask/sdk)@dynamic-labs/iconic)Overrides (root
package.json):Notes:
wsoverride has a version range. It changes only vulnerablews8.x copies. Thews6.x and 7.x copies are not affected by these advisories and do not change. The existingws@8.21.3users do not change.@metamask/sdk@0.33.1pinsdebug@4.3.4(this is the fix). Thusdebug@4.3.4andms@2.1.2are new in the lockfile. Both have no advisory.@dynamic-labs/iconiclistssharpas a dependency, but its code does not importsharp.nextalready usessharp@0.35.4. Now there is only onesharpversion.@dynamic-labs/*lockfile keys change. The versions are the same. Only the peer hashes change (newwsversion, andsharp@0.35.4has@types/nodeas an optional peer).Risk: medium
wsand@metamask/sdkare runtime code in the browser wallet flow (WalletConnect, MetaMask, viem WebSocket transport).ws8.18 -> 8.21 is a minor bump inside the same major. Thewschangelog for 8.19-8.21 has fixes and new options, but no breaking changes.@metamask/sdk0.33.0 -> 0.33.1 is a patch.sharphas almost no risk here, because@dynamic-labs/iconicdoes not load it.How I tested
Local, Node 20.19.6, pnpm 10.33.0. Same steps as
.github/workflows/ci.yml:pnpm install --frozen-lockfilepnpm turbo run build --filter='./packages/*' --forcepnpm turbo run typecheck --forcepnpm turbo run test --forcemain)pnpm turbo run build --filter=@agent-commerce/web --force(CI placeholder env)next start+curlon/,/login,/skill.mdpnpm why ws@8.21.0 / sharp / @metamask/sdk -rpnpm auditmain, 16 on this branch. Nows,sharpor@metamaskfindings.Not fixed in this PR
apps/web).metro@0.80.12declares^1.0.2. Not done.@mysten/sui@1.24.0declares^0.36.0. Not done.query-string@7loads it withrequire(), so the bump breaks it. Not done.uuid@8.3.2and9.0.1(from@metamask/*) need a major bump. A patch for the11.1.0copy does not close the alert. Not done.Most of these need a new
@crossmint/client-sdk-react-uirelease with newer@dynamic-labs/*packages.🤖 Generated with Claude Code