fix(azure): sign copy source with read SAS when committing report - #205
Open
rmarku wants to merge 2 commits into
Open
fix(azure): sign copy source with read SAS when committing report#205rmarku wants to merge 2 commits into
rmarku wants to merge 2 commits into
Conversation
Azure authenticates the copy *source* of a Copy Blob From URL operation independently of the request's shared-key signature. commitPrefix passed a bare, unsigned blob URL to syncCopyFromURL, so against a private container the copy-source read failed with "Server failed to authenticate the request ... www-authenticate header", making every report commit fail on Azure (uploads/downloads were unaffected since those are shared-key signed). Generate a short-lived read-only SAS for the source blob before the copy, mirroring how the S3 backend names its source inside a signed request.
Unit test (node:test, no emulator or network) that stubs listBlobsFlat and the blob client's syncCopyFromURL/deleteIfExists while letting the real generateSasUrl run. Asserts the copy source is a signed read-only SAS URL (sig/se/sp=r present) rather than the bare blob URL. Fails against the previous bare-url code and passes with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure authenticates the copy source of a Copy Blob From URL operation independently of the request's shared-key signature. commitPrefix passed a bare, unsigned blob URL to syncCopyFromURL, so against a private container the copy-source read failed with "Server failed to authenticate the request ... www-authenticate header", making every report commit fail on Azure (uploads/downloads were unaffected since those are shared-key signed).
Generate a short-lived read-only SAS for the source blob before the copy, mirroring how the S3 backend names its source inside a signed request.