Conversation
Documentation build overview
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
CycloneDX 1.7 distinguishes schema-defined families and curves while older consumers still depend on free-form curve metadata. Derive the accepted cases from the bundled schema and gate standardized serialization to the new view. Preserve the legacy value through comparison and rendering, then exercise strict schema output and downgrade behavior. Signed-off-by: Quentin Kaiser <quentin.kaiser@onekey.com>
3883f08 to
fd0ec25
Compare
CAOShurong
left a comment
There was a problem hiding this comment.
I independently tested this exact head and the standardized identifiers behave consistently across the supported views.
Verification performed:
- 344 focused enum/model tests passed;
- the full suite passed (7,305 tests);
- flake8 and mypy passed;
- sdist and wheel builds passed;
- a clean wheel install produced schema-valid CycloneDX 1.7 JSON and XML, round-tripped the new fields, and omitted them while retaining the legacy curve on a 1.6 downgrade.
I did not find a correctness regression in the reviewed scope. Review prepared with OpenAI Codex assistance; I verified the commands, outputs, and conclusion.
jkowalleck
left a comment
There was a problem hiding this comment.
we could add the data fields, but i would not want to have them values implemented as enums here.
the enum values are not part of CycloneDX spec itself, but are part of an extra schema https://github.com/CycloneDX/specification/blob/master/schema/cryptography-defs.schema.json
This schema moves in a differnet pace than the CycloneDX, and i dont want to have an external enum chasing reality.
Description
CycloneDX 1.7 distinguishes schema-defined families and curves while older consumers still depend on free-form curve metadata.
Derive the accepted cases from the bundled schema and gate standardized serialization to the new view. Preserve the legacy value through comparison and rendering, then exercise strict schema output and downgrade behavior.
AI Tool Disclosure
codexgpt-5.6-sol xhighLLM prompt
CryptoAlgorithmFamilyandCryptoEllipticCurveenums. ExtendAlgorithmPropertieswithalgorithm_familyandelliptic_curve, emitted only for 1.7; retain deprecatedcurve.Serialization behavior
SchemaVersion1Dot7, with exact CycloneDX JSON names, XML element names, ordering, nested arrays, and date/hash mappings.Test plan
key-wrap, and protocol types.Assumptions
SortedSetstorage.Affirmation