Conversation
|
Discussion in meeting: Should we skip the BASE64URL encoding? |
|
Mandatory Base64 for UUID/EAN/GTIN/etc. seems to obscure identifiers that are already path-safe, so I’d propose we scope it down. For PURL (and, as noted below, SWID), some encoding is still needed when moving from
So here's what I'd propose:
I looked into NISTIR 8060 to check whether Curious what others think. |
|
I don't have access to the SWID ISO standard but it seems complex to include an XML document into a URL... Anyone that knows more? Is there a simplified tag we can use to indicate a product release? |
|
I've removed BASE64URL on everything except PURLs now. Thanks for the feedback @Mehrn0ush |
|
Good question — TEI doesn't put a SWID XML document in the URL. In the discovery readme, the One follow-up on the latest push, though: since Also, the readme doesn't explicitly say And unrelated to all this: the readme already notes there's a TEI-native |
|
RIght, I did not touch SWID because I had no example. I can do that now. |
|
Some inconsistency issues:
Also some issues vs #258 that would need to be addressed:
One pre-existing security note we can address here Redirect handling on the |
|
Fixed remaining URN examples, moved some comments to issues since they need a separate PR |
Signed-off-by: Olle E. Johansson <oej@edvina.net>
|
Ready for re-review |
| |---|---|---| | ||
| | Enterprise SSO where the customer's identity provider issues SAML assertions | `urn:ietf:params:oauth:grant-type:saml2-bearer` | [RFC 7522](https://www.rfc-editor.org/rfc/rfc7522) | | ||
| | OpenID Connect, or any provider issuing signed JWTs, including workload identity in CI systems | `urn:ietf:params:oauth:grant-type:jwt-bearer` | [RFC 7523](https://www.rfc-editor.org/rfc/rfc7523) | | ||
| | OpenID Connect, or any provider issuing signed JWTs, including workload identity in CI systems | `ietf:params:oauth:grant-type:jwt-bearer` | [RFC 7523](https://www.rfc-editor.org/rfc/rfc7523) | |
There was a problem hiding this comment.
Lost the urn: prefix on the JWT-bearer grant type — it now reads ietf:params:oauth:grant-type:jwt-bearer instead of urn:ietf:params:oauth:grant-type:jwt-bearer. The SAML and token-exchange both still have the urn: prefix.
|
@taleodor are we ready to commit this change? I need it because it's normative. |
taleodor
left a comment
There was a problem hiding this comment.
Issues:
- Line 70 (marked in code)
- Line 303 (marked in code)
- Line 1023 (marked in code)
- spec/openapi.yaml:775 — the tei query parameter for /discovery, the exact endpoint this PR redefines, still carries a URN example
- Both end-to-end /discovery examples are still wrong:
5a. Example 1's TEI keeps a literal placeholder and a URN-style colon: tei:///uuid/products.example.com:d4d9f54a-…. The domain belongs in the authority; the identifier is just the UUID. The URL underneath then encodes a different (correct) string.
5b. Example 2 is the sharper one. Its TEI line is now properly BASE64URL, but the URL beneath it is still the old URN body with the PURL raw: ?tei=tei%3A//products.example.com%3Apurl%3Apkg%3Adeb%2Fdebian%2Fcurl%407.50.3-1%3Farch%3Di386%26distro%3Djessie - TOC anchor is broken — discovery/readme.md:6 still links #the-tei-urn-an-extensible-identifier; the heading is now "The TEI: URL - An extensible identifier".
- The IANA note was deleted, but nothing says about URI scheme registration (where TEI is registered or unregistered)
- SWID removed, but doc/tea-requirements.md:84,92 still lists SWID as supported format
- The UUID in example 1 is not a UUID — d4d9f54a-abcf-11ee-ac79-1a52914d44b has 11 hex digits in the last group
| identifiers: | ||
| - idType: TEI | ||
| idValue: tei:vendor:product@2.24.3 | ||
| idValue: tei://vendor.example.com:product@2.24.3 |
There was a problem hiding this comment.
This doesn't seem like valid TEI.
|
|
||
| ## Port resolution | ||
|
|
||
| Currently, the port number is not part of the TEI but it is needed to connect to the API. |
There was a problem hiding this comment.
Under URL, this is valid tei://host:8443/uuid/… but based on this comment it's not clear what's the meaning here then. I think we should be more explicit about that - say that port shall not be used in TEI.
| like EAN/UPC bar code, PURLs or other existing schemes. A given product release may have multiple identifiers | ||
| as long as they all resolve into the same destination. | ||
| as long as they all resolve into the same destination. In some cases, these identifiers has to be applied | ||
| for to the corresponding standards organisation. |
|
Thank you for a detailed review, it will help moving forward - I will work on this very soon. |
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
|
@taleodor The latest set of commits should fix the issues reported. Please review. |
Still outstanding1. The TOC anchor is still broken. Line 6 links 2. Example 2's URL is still the URN form. Line 336: That decodes to 3. The truncated UUID survives in the 4. Scheme registration, and a now-misleading reference. Line 405 reads "[IANA URI registry]" but links to New in the latest commits5. |
Complete the discovery TEI UUID to 12 hex digits in the last group, and use examples: for tei/purl to match mediaType and the 2020-12 dialect. tei:// form still waits on CycloneDX#261. Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
Signed-off-by: Olle E. Johansson <oej@edvina.net>
|
Fixed issues. Not adding a comment about URL schema at this point, that's for after 1.0. Will make sure we have an issue |
|
Let's merge this. |
Moving away from URN based on feedback from IETF expert group