Conversation
Add Pragma: no-cache beside Cache-Control: no-store, and document form-urlencoded encoding of client credentials before Basic. Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
Collaborator
|
@taleodor what do you think? |
Contributor
|
I think we shouldn't merge this. Pragma is deprecated in RFC 9111 and dropped in OAuth 2.1. I don't think we should mandate a legacy header. |
Contributor
|
Alternatively, maybe remove Pragma completely from PR and just keep encoding part? |
Contributor
Author
|
Good catch — agreed. RFC 6749 includes Pragma: no-cache for HTTP/1.0 compatibility, but RFC 9111 deprecates it and OAuth 2.1 dropped it in favor of Cache-Control: no-store alone. I’ll remove the Pragma requirement from this PR and keep the Basic credential encoding clarification. |
RFC 9111 deprecates Pragma and OAuth 2.1 requires only Cache-Control: no-store. Keep the Basic form-urlencoded encoding clarification. Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
Contributor
Author
|
Thanks @taleodor — that makes sense. I’ve removed the Pragma requirement from this PR and kept the Basic form-urlencoded encoding clarification. |
This was referenced Sep 14, 2026
Collaborator
|
Are we ready to merge @taleodor ? |
taleodor
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pragma: no-cacheon successful token responses alongside existingCache-Control: no-store, per RFC 6749 section 5.1basicAuthscheme that API key identifier and secret are eachapplication/x-www-form-urlencodedencoded beforeuserid:passwordand Base64, per RFC 6749 section 2.3.1auth/readme.mdwith the samePragmaheaderCloses #271
Context
RFC 6749 section 5.1 requires both
Cache-Control: no-storeandPragma: no-cacheon responses that include tokens. OpenAPI previously only declaredCache-Control.RFC 6749 section 2.3.1 requires form-encoding each credential before building the Basic header. That step matters for secrets containing
:,@, or other reserved characters.auth/readme.mdalready described it; the OpenAPIbasicAuthdescription did not.