Skip to content

CI check (fork-only test) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DG47 wants to merge 1 commit into from
Closed

CI check (fork-only test) #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ jobs:
with:
java-version: 8

# The miredot plugin's POM cannot be resolved by Maven 3.10+ (${toolsjar} is
# never set), so pin the last working Maven 3.9 release instead of the runner's.
- name: Set up Maven
run: |
curl -fsSL https://archive.apache.org/dist/maven/maven-3/3.9.16/binaries/apache-maven-3.9.16-bin.tar.gz | tar xz -C "$RUNNER_TEMP"
echo "$RUNNER_TEMP/apache-maven-3.9.16/bin" >> "$GITHUB_PATH"

- name: Maven cache
uses: actions/cache@v4
with:
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ jobs:
with:
java-version: 8

# The miredot plugin's POM cannot be resolved by Maven 3.10+ (${toolsjar} is
# never set), so pin the last working Maven 3.9 release instead of the runner's.
- name: Set up Maven
run: |
curl -fsSL https://archive.apache.org/dist/maven/maven-3/3.9.16/binaries/apache-maven-3.9.16-bin.tar.gz | tar xz -C "$RUNNER_TEMP"
echo "$RUNNER_TEMP/apache-maven-3.9.16/bin" >> "$GITHUB_PATH"

- name: Maven cache
uses: actions/cache@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/ohdsi/webapi/report/CDMResultsAnalysisRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.ohdsi.webapi.source.SourceDaimon;
import org.springframework.dao.DataAccessResourceFailureException;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.PreparedStatementSetter;
import org.springframework.jdbc.core.RowMapper;

/**
Expand Down Expand Up @@ -47,7 +48,7 @@ public void setUp() {
public void getDrilldown_propagatesQueryFailureInsteadOfReturningEmptyResult() {

// Simulate a SQL failure during the drilldown (e.g. unreachable results schema)
when(jdbcTemplate.query(anyString(), any(), any(RowMapper.class)))
when(jdbcTemplate.query(anyString(), any(PreparedStatementSetter.class), any(RowMapper.class)))
.thenThrow(new DataAccessResourceFailureException("simulated SQL failure"));

try {
Expand Down
Loading