Repository navigation
Remove diskcache - #27
Merged
Merged
Conversation
diskcache is unmaintained since 2023 and has an unfixed vulnerability (CVE-2025-69872, unsafe pickle deserialization). Cache() without a directory used a temporary folder per worker process, so a plain dict keeps the same behaviour (per worker, no expiry), only in memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of the API security upgrade stack.
Summary
diskcache: unmaintained since 2023 (last release 5.6.3) and affected by CVE-2025-69872 (unsafe pickle deserialization) without a fix.Cache()was created without a directory, i.e. a temporary folder per worker process. A plaindictkeeps the same behaviour (per worker, no expiry), only in memory.Dockerfile.dev. The lockfile only loses diskcache.How to test
Setup (gregorovius-env):
git -C gregorovius-api switch chore/remove-diskcache,docker compose build gregorovius_api && docker compose up -d gregorovius_api.curl -w '%{time_total}\n' -o /dev/null http://localhost:8069/letterstwice → 200; a repeated call on the same worker returns in ms (2 workers, each with its own cache).https://gregorovius.local/letters/G067797→ letter text and facsimile load.Test plan
poetry run pytest: 21 passed/letters,/persons,/letters/{id}(JSON/XML),/cmif,/beacon/all,/facsimilesreturn 200🤖 Generated with Claude Code