docs: ADR for migration#4
Open
aldbr wants to merge 1 commit into
Open
Conversation
6 tasks
6 tasks
4 tasks
aldbr
force-pushed
the
adr_migration
branch
2 times, most recently
from
aa9a660 to
21809ca
Compare
amaltaro
reviewed
Jul 8, 2026
amaltaro
left a comment
amaltaro
left a comment
There was a problem hiding this comment.
Hello, as we discussed last week during the hackathon, I wanted to leave some feedback on "IC-ADR-002_integration_tests.md" file provided in this PR:
- do we already have a unit test that tests HTCondor >= 25.8, ensuring it is catching the double fetch issue?
- for the credentials setup, is it already in place? should it be a pre-job and then each backend job just uses that file, which is destroyed at the tear down of the full suite of tests?
- how to deal with backend change of APIs (imagine that HTCondor 27 accepts a new parameter, while 26 does not)?
- I might have missed the definition of "leading-edge" and "anchor". It would be helpful to explicitly define it, if not yet.
- I would suggest making a table with minimal version supported for each backend (is it the "anchor" concept?)
I am just getting started with Dirac workflows, so I might have missed things that are already defined and/or that I should know.
However, I have to say that it was hard to follow this document, it is full of (important) details. Perhaps a summary section would be positive (or having it directly in the README or so.
Please let me know if you would like feedback on anything else in specific. Thanks for this thorough document!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.