docs(net-limit): split load usage into egress and ingress lines - #156
Open
yuKing123-king wants to merge 1 commit into
Open
yuKing123-king wants to merge 1 commit into
yuKing123-king wants to merge 1 commit into
Conversation
Signed-off-by: Wang Yu <wangyu6@uniontech.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复的问题
net-limit的usage()帮助文本与实际实现不一致,按文档操作必然踩坑:当前 usage 把
--pin、--rate、--burst、--tgid/--pid/--cgroup-path/--cgroup-id列在load交替分支(--egress | --ingress)之外,暗示这些选项对两个方向都有效。但实际:--ingress路径(do_load,net-limit.cpp:993-1005)解析全部上述选项 ✅--egress路径(do_shape_load,net-limit.cpp:813-823)选项表只有--dev/--egress/--help(解析串"d:eh"),其余一律报错 ❌实测后果:
Note 部分
Run 'net-limit load ... --pin' before add/del/list/stats对 egress 同样是误导:egress 不接受--pin(照做即报错),且 shape 模式本来就无条件 pin 全部 4 个 map(net-limit.cpp:883-902)。改了哪些地方
仅
filter/net-limit.cpp的usage()函数输出文本,不涉及任何逻辑改动