Skip to content

docs(net-limit): split load usage into egress and ingress lines - #156

Open
yuKing123-king wants to merge 1 commit into
DKapture:mainfrom
yuKing123-king:docs/net-limit-usage-split
Open

yuKing123-king wants to merge 1 commit into
DKapture:mainfrom
yuKing123-king:docs/net-limit-usage-split

Conversation

@yuKing123-king

Copy link
Copy Markdown
Contributor

修复的问题

net-limit 的 usage() 帮助文本与实际实现不一致,按文档操作必然踩坑:

当前 usage 把 --pin、--rate、--burst、--tgid/--pid/--cgroup-path/--cgroup-id 列在 load 交替分支(--egress | --ingress)之外,暗示这些选项对两个方向都有效。但实际:

  • --ingress 路径(do_load,net-limit.cpp:993-1005)解析全部上述选项 ✅
  • --egress 路径(do_shape_load,net-limit.cpp:813-823)选项表只有 --dev/--egress/--help(解析串 "d:eh"),其余一律报错 ❌

实测后果:

$ sudo dk-net-limit load --egress --dev enp1s0 --pin
dk-net-limit: unrecognized option '--pin'    # usage 明明写了 [--pin]

Note 部分 Run 'net-limit load ... --pin' before add/del/list/stats 对 egress 同样是误导:egress 不接受 --pin(照做即报错),且 shape 模式本来就无条件 pin 全部 4 个 map(net-limit.cpp:883-902)。

改了哪些地方

仅 filter/net-limit.cpp 的 usage() 函数输出文本,不涉及任何逻辑改动

Signed-off-by: Wang Yu <wangyu6@uniontech.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant