Repository navigation
fix(packs): Mega Evolution odds are estimated, not measured - #20
Merged
Merged
Conversation
Mega Evolution sets inherited the Scarlet & Violet rule, including its 'measured' tier-weight basis, so the catalogue claimed measured odds for an era whose study we do not cite. ME now has its own rule that reuses the ten-card layout with an explicitly estimated basis and a note explaining the carry-over. Tests updated; 132 green. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted on the live catalogue: every Mega Evolution set showed a Measured odds badge, because the era inherited the Scarlet & Violet rule object — including its measured tier-weight basis — while our cited study covers the Scarlet & Violet era, not Mega Evolution.
menow has its own rule built from the SV layout, withconfidence: estimated, an estimatedweightsBasisthat says the shares carry over the SV study's shape, and a note recording the carry-over.me01resolves to themerule and that its basis is estimated.132 tests / 16 files, typecheck, lint and build clean.