Skip to content

Spammy pack openings: stacking pile, rarity sparks/flames, tiered sounds - #28

Merged
DLinacre merged 1 commit into
mainfrom
arena/2830fb6a-pokeguru
Nov 14, 2026
Merged

DLinacre merged 1 commit into
mainfrom
arena/2830fb6a-pokeguru

Conversation

@DLinacre

Copy link
Copy Markdown
Owner

What changed

Spam opening/flipping

  • The reveal stage is now one big repeated-tap target: every tap flips the next card, with no confirmation step, no queueing and no per-flip delay. → and space do the same (space only when it would not scroll or press a focused button).
  • Only the leading face-down card is a button, so tapping a card can never flip a different card than the one you touched (this was a real bug in the previous layout).
  • touch-action: manipulation on the tap target so mobile taps are not swallowed by double-tap zoom.

Cards flip onto each other at the top

  • New RevealPile: every flipped card lands on top of the previous one — offset, slightly rotated, newest on top, with a shadow under the stack and a +n badge once more than four cards are stacked.
  • The pack itself stays in a single grid (flipped cards face up, the rest face down) so a whole pack is still visible without scrolling.

Excitement for rare pulls

  • New PullBurst / PullCelebration: sparks, flames, a warm glow, radial rays and a one-shot vignette, scaled by tier — understated for commons, warm for holo/rare, sparks for double rare and above, sparks + flames for special illustration/hyper/secret.
  • A short callout ("Rare pull!", "Huge pull!!") names the tier; when you are flipping fast it replaces the full-screen celebration so spamming never strobes.
  • All effects are aria-hidden, pointer-events-none, and their particles are hidden outright under prefers-reduced-motion.

Sound on good pulls

  • packSound.ts rewritten as a tiered, synthesised cue set: soft tick for a common flip, a rising arpeggio + shimmer + whoosh for a chase pull, and a sub-bass thump + bell tail for a top-tier pull. A finished pack gets a cheer scaled by how many hits it contained.
  • Rate-limited and overlap-capped, so hammering the reveal stays musical instead of turning into mush. Still silent until you turn sound on.

Accessibility

  • The OS prefers-reduced-motion preference now seeds the motion toggle on a first visit; an explicit choice in the UI always wins afterwards.

Verification

  • npm test — 24 files / 204 tests pass (new coverage: pile growth, spam tapping, arrow/space repeats, rare-pull callouts).
  • npm run lint, npm run typecheck clean; npm run build succeeds.

…and tiered sounds

- One big repeated-tap stage flips the next card; arrow or space works too,
  and the pack grid keeps a single tappable card so a tap never flips the
  wrong card.
- Flipped cards land on a growing, overlapping pile at the top of the stage
  (newest on top) with a landed-card animation, while the pack stays on one
  screen.
- Rare pulls get sparks, flames, a glow, radial rays and a one-shot vignette,
  scaled by tier; rapid flipping downgrades to a short callout so it never
  strobes. Everything is decorative, aria-hidden, and hidden outright under
  prefers-reduced-motion.
- Synthesised WebAudio cues are now tiered (flip/nice/rare/hype) plus a
  per-pack cheer sized by hit count, rate-limited so spamming stays musical.
- The OS reduce-motion preference seeds the toggle on a first visit.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@DLinacre
DLinacre merged commit 073399e into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant