Skip to content

Pick the rare threshold from the set's own rarity ladder - #30

Merged
DLinacre merged 1 commit into
mainfrom
arena/66675182-pokeguru
Nov 14, 2026
Merged

DLinacre merged 1 commit into
mainfrom
arena/66675182-pokeguru

Conversation

@DLinacre

Copy link
Copy Markdown
Owner

Follow-up to #29. When I verified against the live Base Set page, its own panel says:

TCGdex records the first WotC sets' holofoil rares as plain 'Rare' (holofoil is a printing variant there), so those sets draw the rare slot from one combined rare pool instead of separating holo from non-holo.

So a fixed "holo rare or better" line would still have shown a misleading zero on exactly the Base Set packs in the report.

The threshold now comes from the loaded pool:

Pool shape Threshold shown
Modern (SV / SWSH / SM / XY / BW / Mega) Double rare or better
Older set with holos filed separately Holo rare or better
Wizards-era sets with one combined rare tier Rare or better

pullCounts() / resultHighlights() take a hasSeparateHolo option, and PackOpening passes Boolean(pool.tiers.holoRare?.length) through to the summary.

New tests cover all three threshold cases, including the one that matters here: on Base Set, a Charizard counts as a hit and is listed as a real pull.

npm test — 25 files / 213 tests pass; lint, typecheck and build clean.

For Wizards-era sets TCGdex files holo rares as plain 'Rare' (holofoil is a
printing variant there), so the pool for Base Set has no separate holo tier.
A fixed "holo rare or better" line would therefore still have read as a
misleading zero on exactly the packs in the report.

The chase threshold is now chosen from what the loaded pool actually contains:
'rare or better' when holos are not filed separately, 'holo rare or better'
for later old-era sets, and 'double rare or better' for modern ones.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@DLinacre
DLinacre merged commit 26d0f5b into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant