Repository navigation
Pick the rare threshold from the set's own rarity ladder - #30
Merged
Merged
Conversation
For Wizards-era sets TCGdex files holo rares as plain 'Rare' (holofoil is a printing variant there), so the pool for Base Set has no separate holo tier. A fixed "holo rare or better" line would therefore still have read as a misleading zero on exactly the packs in the report. The chase threshold is now chosen from what the loaded pool actually contains: 'rare or better' when holos are not filed separately, 'holo rare or better' for later old-era sets, and 'double rare or better' for modern ones. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29. When I verified against the live Base Set page, its own panel says:
So a fixed "holo rare or better" line would still have shown a misleading zero on exactly the Base Set packs in the report.
The threshold now comes from the loaded pool:
pullCounts()/resultHighlights()take ahasSeparateHolooption, andPackOpeningpassesBoolean(pool.tiers.holoRare?.length)through to the summary.New tests cover all three threshold cases, including the one that matters here: on Base Set, a Charizard counts as a hit and is listed as a real pull.
npm test— 25 files / 213 tests pass; lint, typecheck and build clean.