Fixed the disabling of the data writing in the TPStreamWriterModule

[bieryAtFnal]

Description

Some time ago, Michal reported that the --disable-data-storage option that is part of the run control start command was not causing TPStream file writing to be disabled (even though it disables the writing of raw data files).

It turns out that the "output disable" logic had not been included in the TPStreamWriterModule. This PR fixes that.

In addition, the change in this PR add the checking of the number of TPStream files written in the disabled_output_test.py regression test, which was another oversight. With the changes in this PR, this regression test runs successfully and verifies that there are no TPStream files written to disk when the --disable-data-storage flag is used.

Here are suggested instructions for testing these changes:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260716_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop
git clone https://github.com/DUNE-DAQ/dfmodules.git -b kbiery/tpsw_output_disable

cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r dfmodules -k disable

echo ""
echo -e "\U1F535 \U2705 Note that the disabled_output_test ran successfully, including the correct number of TPStream files. \U2705 \U1F535"
echo ""
echo ""

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing checklist

• Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

I will clang-format the TPStreamWriter code as a separate step...

[eflumerf]

Looks good. Updated integration test works fine

[MRiganSUSX]

@bieryAtFnal thanks for fixing this.

I can confirm that both the integtest and manual test at ehn1 are working as expected.

The only slightly confusing thing (by name, but not by logic) is this line: https://github.com/DUNE-DAQ/dfmodules/pull/498/changes#diff-e0e9ec26380105e172909297cd78764ed16f891a809a7c78d7c83a0bb56c83aeR231 where it could be confusing to set expectation on TPG based on data files (by name only).