You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exposes the existing dagshub.upload.create_dataset helper as a CLI command, so users can create a repo and upload a local dataset folder without writing Python.
Adds dagshub create_dataset REPO_NAME LOCAL_PATH with --glob-exclude, --org-name, --private and --host
Adds CLI unit tests with a mocked backend (2 passing). flake8 is clean on the changed files.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4b182052-9a9b-41fa-beaa-7f888dca8396
Commits
Reviewing files that changed from the base of the PR and between 0e592ce and 9fe466f.
Files selected for processing: 1
dagshub/common/cli.py
Files skipped from review as they are similar to previous changes: 1
dagshub/common/cli.py
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
Recent review details
Context from checks skipped due to timeout: 1
GitHub Check: CodeRabbit
Walkthrough
The CLI now provides a create_dataset command that creates a dataset repository from an existing local directory. Tests verify option forwarding and rejection of a nonexistent directory.
Changes: Dataset CLI
Layer / File(s)
Summary
Register and validate dataset creation command dagshub/common/cli.py, tests/common/test_cli_create_dataset.py
The CLI accepts a repository name, local directory, and creation options, then calls create_dataset and logs the repository address. Tests check the forwarded arguments and nonexistent-directory handling.
The command’s host handling and dataset creation delegation are consistent with the existing behavior. No identified issue prevents merging after normal checks.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "Add create_dataset CLI command" matches the main change. The changeset adds a create_dataset CLI command in dagshub/common/cli.py that exposes the existing `dagshub.upload.create_datase…
Description check
The description states that the change exposes the existing dagshub.upload.create_dataset helper as a CLI command. It lists the command syntax, the --glob-exclude, --org-name, --private, and `…
Linked Issues check
The changes satisfy issue #244. dagshub/common/cli.py registers dagshub create_dataset with repository and existing-directory arguments. It exposes --glob-exclude, --org-name, --private, and…
Out of Scope Changes check
The diff contains the CLI command, the public create_dataset import, and focused CLI tests. Each change supports issue #244. No unrelated product behavior or files appear in the reviewed diff.
Full details: Title check
Explanation
The title "Add create_dataset CLI command" matches the main change. The changeset adds a create_dataset CLI command in dagshub/common/cli.py that exposes the existing dagshub.upload.create_dataset helper. The title is short, specific, and names the primary change.
Full details: Description check
Explanation
The description states that the change exposes the existing dagshub.upload.create_dataset helper as a CLI command. It lists the command syntax, the --glob-exclude, --org-name, --private, and --host options, and the added CLI unit tests. It matches the changeset.
Full details: Linked Issues check
Explanation
The changes satisfy issue #244. dagshub/common/cli.py registers dagshub create_dataset with repository and existing-directory arguments. It exposes --glob-exclude, --org-name, --private, and --host. It applies CLI settings and calls dagshub.upload.create_dataset with the dataset arguments. tests/common/test_cli_create_dataset.py covers argument forwarding and invalid directory handling.
Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit taps the command with care A dataset starts from files laid there Options pass along the way Missing paths are turned away The repo address joins the day
Comment @coderabbitai help to get the list of available commands.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: f04b2933-6e6d-416b-b2e8-8fac1325e1cd
Commits
Reviewing files that changed from the base of the PR and between 4f7d78a and 0e592ce.
Files selected for processing: 2
dagshub/common/cli.py
tests/common/test_cli_create_dataset.py
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the existing
dagshub.upload.create_datasethelper as a CLI command, so users can create a repo and upload a local dataset folder without writing Python.dagshub create_dataset REPO_NAME LOCAL_PATHwith--glob-exclude,--org-name,--privateand--hostCloses #244