Repository navigation
fix: [TA-253] Daum 우편번호 스크립트 렌더 차단 + 미가드 - #140
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seorinn
marked this pull request as ready for review
June 29, 2026 08:36
seorinn
added a commit
that referenced
this pull request
Sep 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
public/index.htmlhead의postcode.v2.js동기<script>제거 → 모든 페이지 첫 렌더 차단 해소src/utils/loadDaumPostcode.ts신규: 필요 시점에 1회 지연 로드(진행 중 Promise 공유, 실패 시 캐시 해제+노드 정리, onload 후 전역 미설정도 실패 처리)EditPhotographerPage:handleAddressSearch를 async로 전환 →await loadDaumPostcode()후 검색창 오픈, 실패 시 안내 alert 폴백.Window.daum을 optional로 정정배경
우편번호 스크립트가 head 동기 로드라 사용처(EditPhotographerPage)와 무관하게 전 페이지 첫 렌더를 차단했고, CDN 실패 시
window.daumundefined로 미처리 에러가 났음.테스트
loadDaumPostcode.test.ts신규 5케이스: 이미 로드 즉시 resolve / onload+전역 설정 resolve / onload+전역 미설정 reject+노드정리 / 실패 reject+캐시해제 재주입 / 동시호출 1회 주입리뷰
Opus 코드리뷰: 머지 가능. 지적된 onload 후 전역 가드·실패 노드 정리 반영 완료.
Closes TA-253