Repository navigation
Reuse planned file metrics for eager Iceberg column statistics (no double IO) - #32
Draft
alexanderbianchi wants to merge 1 commit into
Conversation
Request column statistics from the scan (iceberg-rust with_column_stats, apache/iceberg-rust#3424) and summarize them from the planned FileScanTasks instead of re-reading manifests, avoiding double IO. Bump iceberg-rust to 13f84f9 (Arrow 60 plus #3424), patching datafusion-iceberg to the same revision so FileScanTask is one type, and adapt to its API (UnboundPartitionField builder, FileScanTaskDeleteFile accessors). Adapt the column byte statistics tests to DataFusion 56.
alexanderbianchi
changed the base branch from
alex.bianchi/dd-source-iceberg-stats-20261029
to
alex.bianchi/dd-source-iceberg-stats-20261029-df56
November 17, 2026 02:57
alexanderbianchi
force-pushed
the
alex.bianchi/dd-source-iceberg-stats-single-pass
branch
from
November 17, 2026 02:57
239ffcd to
42e904b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Stacked on DataFusion 56 (datafusion-contrib#851) plus the dd-source stats hooks, rebased from the DataFusion 55 line (old head kept at
alex.bianchi/dd-source-iceberg-stats-single-pass-df55).Eager column statistics used to re-read the snapshot's manifests after planning. Now the scan requests
with_column_statsfor the statistics columns, and statistics are summarized from each plannedFileScanTask::column_stats()(apache/iceberg-rust#3424). Lazy path unchanged.Dependencies: iceberg-rust bumped to apache/iceberg-rust
13f84f9(Arrow 60 plus #3424), fetched via DataDog/iceberg-rust, which mirrors it. A root[patch]points datafusion-iceberg (apache/datafusion-iceberg#99 at 5398be1) at the same revision soFileScanTaskis one type. Adapted to its API (UnboundPartitionFieldbuilder,FileScanTaskDeleteFileaccessors).Notes:
take_column_stats, so the retained metrics now stay on the tasks and are serialized to workers with them.join_selection_can_build_derived_keys...test: DataFusion 56 already builds the derived keys without the provider, so only the provider-enabled outcome is asserted.Tests:
cargo test -p datafusion-distributed-icebergand-p datafusion-distributed --libpass; clippy on the iceberg crate is clean. Core crate clippy fails on an unusedPRODUCER_SALT_DEFAULTimport that is not from this change.