Repository navigation
[SDS-3136] Add Japan driving license checksum - #405
Merged
GeoffreyRdn merged 2 commits intoOct 29, 2026
Merged
Conversation
GeoffreyRdn
force-pushed
the
geoffrey.redon/SDS-3136-japan-driver-license-checksum
branch
from
October 28, 2026 15:15
8ced893 to
95c6711
Compare
GeoffreyRdn
marked this pull request as ready for review
October 29, 2026 09:06
trosenblatt
approved these changes
Oct 29, 2026
GeoffreyRdn
deleted the
geoffrey.redon/SDS-3136-japan-driver-license-checksum
branch
October 29, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
JapanDrivingLicenseChecksumas a secondary validator. Reuses the weighted mod-11 helper over the first ten digits, checks digit 11, and excludes the final reissuance digit.SDS-3136: add checksum validation for Japanese driving licence numbers.
Additional Notes
The NPA circular §1(4) confirms modulus 11, but does not publish weights or remainder handling. The implementation combines WDIC and Resource Sharing.
Sources disagree on remainder zero: a Delphix input example implies check digit 0. We chose 1 following WDIC and Fujii's explicit rule. This decision is documented in the engine; it is not officially confirmed. Positive fixtures do not independently validate exceptional remainders.