Skip to content

[SDS-3137] Add Japan My Number checksum - #406

Merged
GeoffreyRdn merged 4 commits into
mainfrom
geoffrey.redon/SDS-3137-japan-my-number-checksum
Oct 29, 2026
Merged

GeoffreyRdn merged 4 commits into
mainfrom
geoffrey.redon/SDS-3137-japan-my-number-checksum

Conversation

@GeoffreyRdn

@GeoffreyRdn GeoffreyRdn commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add JapanMyNumberChecksum and register it as a secondary validator.
  • Reuse the weighted modulo-11 helper with the algorithm defined in Article 5 of Japanese ordinance No. 85.
  • Cover published and generated examples, spaced formatting, invalid checksums/lengths, and remainder-0/1 edge cases.

@GeoffreyRdn
GeoffreyRdn marked this pull request as ready for review October 29, 2026 09:07
@GeoffreyRdn
GeoffreyRdn requested a review from a team as a code owner October 29, 2026 09:07
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0a9410b | Docs | Give us feedback!

@GeoffreyRdn
GeoffreyRdn force-pushed the geoffrey.redon/SDS-3137-japan-my-number-checksum branch from 40ac41a to 0a9410b Compare October 29, 2026 09:58
@GeoffreyRdn
GeoffreyRdn merged commit 4ba3e46 into main Oct 29, 2026
5 checks passed
@GeoffreyRdn
GeoffreyRdn deleted the geoffrey.redon/SDS-3137-japan-my-number-checksum branch October 29, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants