Skip to content

[SDS-3138] Add Japan Corporate Number checksum - #408

Merged
GeoffreyRdn merged 4 commits into
mainfrom
geoffrey.redon/SDS-3138-japan-corporate-number-checksum
Oct 29, 2026
Merged

GeoffreyRdn merged 4 commits into
mainfrom
geoffrey.redon/SDS-3138-japan-corporate-number-checksum

Conversation

@GeoffreyRdn

Copy link
Copy Markdown
Contributor

Summary

  • Add JapanCorporateNumberChecksum for 13 ASCII digits, with the first digit checked against the alternating-weight modulo-9 formula.
  • Reuse get_next_digit and keep checksum tests in the validator module.
  • Cover official NTA examples, every remainder, invalid check digits, and malformed inputs.

Sources

Validation

  • cargo test --lib --all-features: 507 passed.
  • cargo fmt --all -- --check: passed.
  • Strict Clippy: 24 existing diagnostics, identical on unchanged main.

Shared-rule wiring follows after the core release/dependency bump.

Jira: https://datadoghq.atlassian.net/browse/SDS-3138

@GeoffreyRdn
GeoffreyRdn marked this pull request as ready for review October 29, 2026 09:08
@GeoffreyRdn
GeoffreyRdn requested a review from a team as a code owner October 29, 2026 09:08
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a77b38b | Docs | Give us feedback!

@GeoffreyRdn
GeoffreyRdn merged commit ece1e93 into main Oct 29, 2026
5 checks passed
@GeoffreyRdn
GeoffreyRdn deleted the geoffrey.redon/SDS-3138-japan-corporate-number-checksum branch October 29, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants