ci: skill to review release proposal PRs - #2394
Draft
iunanua wants to merge 3 commits into
Draft
Conversation
Document the crates.io release-proposal flow end to end: the dispatch workflow, how the semver bump level is derived, what CI validates on the proposal PR, and the manual GitLab publish job. Calls out the semver-level.sh / major-bumps-level.sh limitations (they only under-estimate, so minor and patch bumps are the ones to review), that the hotfix path is implemented but untested, and a troubleshooting table. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
|
🎯 Code Coverage (details) 🔗 Commit SHA: bbcd408 | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
hoolioh
marked this pull request as ready for review
August 31, 2026 10:48
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60cb56f63d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| print(f"{d:28} {'PUB' if m['publish'] else '-':4} {(b['ver'] if b else '?'):10} {m['ver']:10} {bumped:16} {direct}") | ||
| PY | ||
| ``` | ||
| Any `PUB` crate flagged `** NOT-MAJOR **` is a defect: it either needs adding to the release as a major bump, or (if already in the list) its bump needs raising to major. Remember the intra-closure requirement edges must also move to the new majors (e.g. `crashtracker → telemetry ^N`). |
There was a problem hiding this comment.
Run this blanket closure check only for major-bumped crates that fail the preceding safe-to-duplicate test. As written, a proposal that major-bumps a crate which passes both checks will still cause every publishable reverse dependent to be reported as a defect, directly contradicting the earlier no cascade verdict and prompting unnecessary major releases.
Useful? React with 👍 / 👎.
gh-worker-ownership-write-b05516
Bot
removed the request for review
from a team
September 2, 2026 13:00
The bump rules classified any additive diff as minor ("new pub items,
nothing removed/changed"), which contradicted the skill's own note that
added trait impls can break inference. Adding an enum variant, a required
trait method, or a field to a constructible struct breaks downstream
matches, impls, and literals, so a reviewer following the rule could
approve a breaking change as a minor release.
- List the four additive-but-breaking forms under major, each with the
exemption that must be verified in code (#[non_exhaustive] at the base
ref, a default body, a pre-existing private field).
- Require subagents to walk that list before returning minor.
- Replace the scripts/tests/semver-level/ citation: no such directory,
detection_matrix.bats, or README exists in the tree. Point at
semver-level.sh, the workflow tool pins (0.48.0, not the claimed
0.47.0), and cargo semver-checks --list instead.
- Note that --list's type column is the required update, not the lint
level, so a major-typed lint can still be warn-level and exit 0.
iunanua
marked this pull request as draft
September 2, 2026 15:27
iunanua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Include a claude skill to review a libdatadog release-proposal PR that bumps multiple crate versions.