Conversation
# Conflicts: # datajunction-server/datajunction_server/models/deployment.py
Persist reaggregation parameters on frozen measures and include them in measure identity and pre-aggregation matching. Thread the parameters into decomposition and Druid metric spec construction, with migration and API coverage.
Pass the output dialect and source aggregation call through metric decomposition so dialect-specific combiners can be rendered correctly. Add family-based registration so sketch decompositions can be selected explicitly through a metric's reaggregation spec.
shangyian
reviewed
Sep 22, 2026
shangyian
left a comment
shangyian
left a comment
Collaborator
There was a problem hiding this comment.
Can we add some tests that assert the setup with the full generated SQL end-to-end, at both the measures layer and the final metrics layer? Just to verify that it all looks reasonable
|
|
||
| Args: | ||
| node_revision_id: ID of the metric node revision | ||
| dialect: Dialect the combiner will be rendered for. Combiners are |
Collaborator
There was a problem hiding this comment.
Are there cases where there is no combiner for Spark but exists one for Druid?
added 2 commits
September 22, 2026 10:10
Allow components to serialize accumulated values for specific materialization targets and declare the resulting type. Add multi-argument type inference and fixed merge arguments so t-digest measures retain the correct representation and compression when written to Druid.
robinld
force-pushed
the
robind/dialect-aware-sketch-decomposition
branch
from
September 22, 2026 18:22
bfba773 to
a2c80ce
Compare
Member
robinld
changed the base branch from
robind/reaggregate-params
to
bdealmeida/reaggregate-params
September 24, 2026 04:02
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.