Conversation
A metric's required_dimensions could reference a role-qualified dimension attribute (e.g. date.dateint[created_date]) but the role was silently stripped during validation. This caused three problems: non-deterministic query-time join resolution, no validation that a declared role actually resolves to a reachable dimension link, and deploy round-trips that never converge because export could never reproduce a role that was already dropped at write time. Replace the metric_required_dimensions join table (which stored an FK to a Column, shared across roles) with a normalized shape that stores the authored reference verbatim (`ref`) plus an indexed FK to the dimension node (`dimension_id`, nullable for a bare parent-column ref). This makes required_dimensions round-trip exactly through export/diff, lets query-time resolution use the exact declared role instead of a fallback sort, and lets dimension-deletion impact analysis see metrics that depend on a dimension only through required_dimensions. Includes a migration with a backfill for existing rows, updated validation (role reachability against a direct parent's dimension links, including through derived-metric composition), and updated read/write/build paths.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan