Checks lookup using index - #2578
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
checks-lookup-index
branch
from
September 24, 2026 08:22
85dc3e7 to
238a384
Compare
shangyian
marked this pull request as ready for review
September 24, 2026 08:23
shangyian
force-pushed
the
checks-lookup-index
branch
from
September 24, 2026 08:46
238a384 to
d02d165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes sure that checks are looked up using the right indexes. Previously we were ordering the candidates in SQL with
length(namespace), but that means indexes can't be used, so the database was reading every deployment for a namespace.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan