Skip to content

Live tests: DataLab 1.4 exits at startup (SIGIMAX_DO_NOT_QUIT not set) #7

Closed

Description

@PierreRaybaut

Problem

datalab_kernel/tests/conftest.py starts DataLab for the live tests (--start-datalab) with DATALAB_DO_NOT_QUIT=1 (and GUIDATA_UNATTENDED=1). DataLab 1.4 (develop) reads its execution environment from SigimaX: the variable is now SIGIMAX_DO_NOT_QUIT (sigimax.env, DO_NOT_QUIT_ENV). In unattended mode DataLab then quits right after starting, and every live test errors:

RuntimeError: DataLab process exited immediately with code 0.

Setting SIGIMAX_DO_NOT_QUIT=1 in addition makes the live tests pass against DataLab develop (checked locally while working on #4).

The CI of main installs DataLab from PyPI, so it is not affected yet; it will be once DataLab 1.4.0 is released.

Proposal

Set both variables in _start_datalab() (DATALAB_DO_NOT_QUIT for DataLab ≤ 1.3, SIGIMAX_DO_NOT_QUIT for 1.4 and later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions