Repository navigation
fix(welcome): follow color mode changes in subdued texts - #395
Merged
Merged
Conversation
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching the color mode in the settings, the secondary texts of the welcome page and of the Applications catalog (descriptions, section titles, slogan) kept the colors of the former mode: black on a dark background after a light to dark switch, white on a light background after a dark to light switch. The rendering was correct only after a restart.
Subdued colors are explicitly set on widgets, so they did not follow the application palette. They are now derived from the current text color (half opacity, as Qt placeholder texts) and refreshed after each color mode change.
A regression test switches light, dark, then light through the settings code path and checks the contrast of subdued texts with the background.