Skip to content

Follow the contract versions of Sigima 1.4 in provenance tests - #428

Merged
PierreRaybaut merged 1 commit into
developfrom
fix/contract-versions-1.4
Oct 25, 2026
Merged

PierreRaybaut merged 1 commit into
developfrom
fix/contract-versions-1.4

Conversation

@PierreRaybaut

Copy link
Copy Markdown
Contributor

Companion of DataLab-Platform/Sigima#88 (closes DataLab-Platform/Sigima#87), same branch name so that the CI tests both together.

Summary

Sigima 1.4 increases to version 2 the contracts of the operations whose result changed for some inputs, among which sigima.signal.difference, average and signals_to_image. Activities recorded with version 1 are now refused explicitly (unsupported_contract) instead of being replayed and reported as different.

The provenance tests hard-coded version 1. They now:

  • expect the activities recorded in the session at the local contract version, replayed exactly (all of them, in the families round trip);
  • expect the reference files of both editions (recorded with version 1) to be refused explicitly, without computation (provenance_*_difference.h5, activities of provenance_*_families.h5 whose contract changed);
  • check that a call recorded with version 1 (provenance_web_difference.h5) is described but not applied again; 2-to-1 re-application stays covered by test_difference_keeps_source_and_operand (calls recorded in the session).

No change to DataLab itself. The reference files are kept as they are: they now check the explicit refusal of earlier recordings. DataLab-Web will have to write its reference files again when it moves to Sigima 1.4.

Tests

datalab/tests/features/common and datalab/tests/features/hdf5 with Sigima fix/contract-versions-1.4 and DataLab-Capsule develop: 508 passed.

Sigima 1.4 increases to version 2 the contracts of the operations whose
result changed for some inputs (DataLab-Platform/Sigima#87), among which
sigima.signal.difference, average and signals_to_image. Activities recorded
with version 1 are now refused explicitly (unsupported_contract) instead of
being replayed.

The provenance tests no longer hard-code version 1: activities recorded in
the session are expected at the local contract version and replayed
exactly; the reference files of both editions, recorded with version 1,
are expected to be refused explicitly, without computation, and a call
recorded with version 1 is described but not applied again.

Assisted-by: Claude Opus 5.5
@PierreRaybaut
PierreRaybaut merged commit 385250d into develop Oct 25, 2026
6 checks passed
@PierreRaybaut
PierreRaybaut deleted the fix/contract-versions-1.4 branch October 25, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant