Repository navigation
Follow the contract versions of Sigima 1.4 in provenance tests - #428
Merged
Merged
Conversation
Sigima 1.4 increases to version 2 the contracts of the operations whose result changed for some inputs (DataLab-Platform/Sigima#87), among which sigima.signal.difference, average and signals_to_image. Activities recorded with version 1 are now refused explicitly (unsupported_contract) instead of being replayed. The provenance tests no longer hard-code version 1: activities recorded in the session are expected at the local contract version and replayed exactly; the reference files of both editions, recorded with version 1, are expected to be refused explicitly, without computation, and a call recorded with version 1 is described but not applied again. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of DataLab-Platform/Sigima#88 (closes DataLab-Platform/Sigima#87), same branch name so that the CI tests both together.
Summary
Sigima 1.4 increases to version 2 the contracts of the operations whose result changed for some inputs, among which
sigima.signal.difference,averageandsignals_to_image. Activities recorded with version 1 are now refused explicitly (unsupported_contract) instead of being replayed and reported as different.The provenance tests hard-coded version 1. They now:
provenance_*_difference.h5, activities ofprovenance_*_families.h5whose contract changed);provenance_web_difference.h5) is described but not applied again; 2-to-1 re-application stays covered bytest_difference_keeps_source_and_operand(calls recorded in the session).No change to DataLab itself. The reference files are kept as they are: they now check the explicit refusal of earlier recordings. DataLab-Web will have to write its reference files again when it moves to Sigima 1.4.
Tests
datalab/tests/features/commonanddatalab/tests/features/hdf5with Sigimafix/contract-versions-1.4and DataLab-Capsuledevelop: 508 passed.