Repository navigation
Web API: give uploaded objects their own identity - #435
Merged
Merged
Conversation
An object downloaded from the Web API keeps its UUID in its metadata.
Uploading it again under another name (PUT /objects/{name}/data, e.g.
DataLab-Kernel's rename) created an object with the UUID of the original
one: the panel refused it, the error was shown in a modal dialog on the Qt
main thread, and the request hung until the 30-second main-thread timeout.
PUT /objects/{name}/data creates (or replaces) an object: the adapter now
gives it a new UUID, whatever the archive carries, and adds it with the
panel method that raises errors instead of showing them, so that the API
returns an error response. Updating an object in place (PUT /objects/{name})
still keeps its identity.
Closes #434
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #434