Repository navigation
Follow Sigima: image profiles in physical coordinates - #437
Merged
Merged
Conversation
Sigima now defines line, segment, average and radial profiles in physical coordinates (renamed parameters, contracts version 2): - the profile dialog exchanges physical coordinates with the drawn shapes, bringing points beyond the image back to the outermost pixel centers and drawing undefined average bounds on the image edges; - the last profile position is still reused as initial shape; - tests use the new parameter names; the families reference checks are data-driven (activities recorded with an older contract version are refused) and the Desktop reference file is regenerated; - documentation, tutorials, release notes and French translations. Closes #436 Assisted-by: Claude Opus 5.5
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436 — companion of DataLab-Platform/Sigima#98 (same branch name, picked by CI).
Summary
Sigima now defines image profiles in physical coordinates (renamed parameters, contracts v2). DataLab follows:
profiledialog.py): drawn shapes are committed as physical coordinates (no morephysical_to_indicesround trip). Lines/segments drawn beyond the image are brought back to the outermost pixel centers (instead of being refused by Sigima); undefined average bounds (None) are drawn on the image edges; parameters remembered from another image are fitted into the current one.update_from_obj); the last profile position is still reused as the initial shape.profile_dialog_physical_unit_test.py(calibrated anisotropic image: commit, clipping, initial shape, remembered position). Families reference checks are now data-driven: an activity recorded with an older contract version must be refused (unsupported_contract), others replayed exactly. Desktop families reference file regenerated (line_profile v2); the Web file (v1) is refused as expected.Validation
features/image,features/common,features/hdf5: 589 passed (against the Sigima branch).