Repository navigation
Fix main CI with Sigima 1.3.0: pixel-coordinate tests and Sigima >= 1.3.0 - #441
Merged
Merged
Conversation
…rs (#400) Sigima now displays the Gaussian, 2D ramp, sinusoidal grating, ring, Siemens star and 2D sinc images over their [xmin, xmax] x [ymin, ymax] domain. Tests relying on pixel coordinates (geometry transforms, analysis recompute) now request them explicitly, and a new test checks that creation parameters stored by earlier versions (object metadata and history) keep pixel coordinates when the image is recreated. Assisted-by: Claude Opus 5.5
Sigima 1.3.0 creates Gaussian, 2D ramp, sinusoidal grating, ring, Siemens star and 2D sinc images in physical coordinates. The tests ported from develop disable this through the new "physical_coords" option, which does not exist in Sigima 1.2.x: raise the minimum requirement accordingly (regenerated requirements.txt and doc/requirements.rst) and document it in the 1.3.1 release notes. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The weekly "Install and Test on Ubuntu (latest)" workflows fail on
mainsince Sigimamainmoved to v1.3.0 (runs 40308538697 and 40309790319, PyQt5 and PyQt6: 8 failures each).Sigima 1.3.0 creates Gaussian, 2D ramp, sinusoidal grating, ring, Siemens star and 2D sinc images in physical coordinates (DataLab-Platform/Sigima#74). The geometry transform and analysis recompute tests define their ROIs and geometries in pixel coordinates, so the 2D Gaussian test images no longer matched them (NaN centroids, mirrored coordinates).
What
develop: these tests now request pixel coordinates explicitly (physical_coords=False), and a new test checks that creation parameters stored by earlier versions keep pixel coordinates when the image is recreated.physical_coordsoption does not exist in Sigima 1.2.x (pyproject.toml, regeneratedrequirements.txtanddoc/requirements.rst), and document it in the 1.3.1 release notes (EN + FR).Validation
build_latestjobs dispatched on this branch for both PyQt5 and PyQt6 workflows.