Repository navigation
feat(plugins): add "New group" option to instrument windows - #443
Merged
Merged
Conversation
Acquisitions of plugin instruments always created a new group. A "New group" check box next to Acquire now lets the user add them to the current group of the panel instead (a group is still created when the panel has no current group). PluginInstrument.new_group sets the default state, and the user's choice is remembered per instrument. Closes #442 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442
Summary
PluginInstrument.new_group(defaultTrue) sets the default state; the user's choice is remembered per instrument (instrument_new_groupoption, keyplugin_id/tool_id).plugins.rst, release notes 1.4) and French translations (UI and doc).Tests
test_instrument_new_group_option(current group, persistence, plugin default, empty panel).