Repository navigation
fix(plugins): add acquisitions to the group chosen when Acquire is clicked - #446
Merged
Merged
Conversation
…icked The instrument window read the "New group" option and the current group of the panel once the acquisition was done: selecting another group or toggling the option while a (possibly long) acquisition was running, or waiting for the end of a preview, changed where the acquired objects went. The option and the current group of each panel are now taken when Acquire is clicked (AcquisitionTarget) and carried with the call of the instrument, so that a request made during a running acquisition does not change its destination either. A new group is created if the chosen group was removed meanwhile, as in DataLab-Web. Closes #445 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #445
Summary
AcquisitionTarget), instead of being read once the acquisition is done. Before, selecting another group or toggling the option while an acquisition was running (or waiting for the end of a preview) changed where the acquired objects went.SIG_CALL_DONEreturns it with the result), so that a request made during a running acquisition does not change its destination either.InstrumentWindow.add_acquisition(acquisition, target=None): without a target, the current state is used (unchanged behavior for direct calls).plugins.rst, release notes 1.4) and French translations updated.Tests
test_instrument_acquisition_target(acquisition blocked while the test selects another group, toggles the option, or removes the chosen group); it fails without the fix.test_live_mode_after_acquisition: the main window double now provides the panels whose current group is taken when Acquire is clicked.datalab/tests/features/plugins,datalab/tests/backbone/pluginsand the configuration persistence test pass (308 tests), as well as the desktop adapter test of datalab-tango.