Repository navigation
fix(history): no oversized reconnection warning when deleting a group of raw objects - #452
Merged
PierreRaybaut merged 2 commits intoOct 28, 2026
Merged
Conversation
Deleting a group of signals or images whose results were kept in another
group showed an oversized "Delete" warning, even when the History panel
was not recording: one line per deleted object, labelled with its raw
UUID, although there was nothing to reconnect.
- find_reconnection_source: only compute actions have a source; UI
creation/loading actions report none, whatever their recorded selection.
- plan_reconnection: report an unreconnected operation only when a
recorded processing step loses its source (ReconnectionPlan.warning
becomes unreconnected_operation, holding the operation title).
- apply_reconnection_plan: apply only when the source is still alive.
- show_reconnection_warnings: a single message listing each operation
once, capped at MAX_LISTED_UNRECONNECTED lines ("... and N more").
- Regression test of group deletion with and without recording, and unit
tests of raw-object planning and message aggregation.
Closes #451
Assisted-by: Claude Opus 5.5
…anslations) Describe when the reconnection warning is shown in the History panel guide, add the 1.4.0 bug-fix note, and update the French translations (UI message, guide and release notes). Refs #451 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451.
Problem
Deleting a group of signals or images whose processing results were kept in another group showed an oversized "Delete" warning (OK button only), even when the History panel was not recording: one line per deleted object, labelled with its raw UUID, stating that operations could not be reconnected although there was nothing to reconnect.
Changes
find_reconnection_source: only compute actions have a source; UI creation/loading actions report none, whatever their recorded selection.plan_reconnection: report an unreconnected operation only when a recorded processing step loses its source (ReconnectionPlan.warning→unreconnected_operation, holding the operation title).apply_reconnection_plan: apply only when the source is still alive.show_reconnection_warnings: a single message listing each operation once, capped at 10 lines ("... and N more").Tests