Repository navigation
Curve readability: automatic styles by position, user styles kept, reset action - #454
Merged
Merged
Conversation
- Visible curves are given the automatic style of their position among the curves shown, in the order of the signals in the panel; curves whose color or line style was chosen by the user keep it - Creating plot items for the panel no longer uses the global style cycle, so that the first curves shown always get the first styles - View > Reset curve styles now removes the colors and line styles stored for the selected signals, which get automatic styles again - Export `CurveStyles` and `LINE_STYLE_KEYS` from datalab.adapters_plotpy - Requires SigimaX changes of DataLab-Platform/SigimaX#28 Refs #453 Assisted-by: Claude Opus 5.5
- View menu: automatic curve styles by position, user styles, and the new behavior of Reset curve styles - Settings: thin curves drawn one screen pixel wide on HiDPI screens - Release notes 1.4.0: Curve readability - French translations Refs #453 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #453.
Depends on PlotPyStack/PlotPy#81 (cosmetic pen, merged into PlotPy
develop) and DataLab-Platform/SigimaX#29 (palette, grid, automatic styles), which close PlotPyStack/PlotPy#80 and DataLab-Platform/SigimaX#28.Changes
Style assignment by position
SignalPlotHandler.update_automatic_styles()runs at the end of each plot refresh.Global style cycle
CURVESTYLES.suspend()).Reset curve styles
Exports
datalab.adapters_plotpynow exportsCurveStylesandLINE_STYLE_KEYS.Documentation and translations
Before / after
With 15 noisy signals, light and dark themes:
Tests
datalab/tests/features/signal/curve_styles_unit_test.py, covering:datalab/tests/features/signal,features/common,features/hdf5andbackbone: 890 passed, 1 skipped;features/image,features/pluginsandfeatures/control: 186 passed, 2 skipped.