Repository navigation
Sharp logos and scaled text with Windows display scaling - #461
Merged
Merged
Conversation
The splash screen, the welcome page and guided tour logos and the plot watermark were blurry with a display scaling greater than 100% (e.g. 125%): they only existed as PNG files rendered for a 100% scaling, which Qt upscaled. scripts/build_resources.py gets a new "logo" target, which renders the images displayed by the application from their SVG source together with their @2x high-resolution variant (CairoSVG). The welcome page and guided tour logos are loaded with guidata's get_pixmap, which uses these variants (the splash screen and the watermark are loaded by SigimaX). Refs #460 Assisted-by: Claude Opus 5.5
…lations) Refs #460 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #460 (related: PlotPyStack/guidata#121, DataLab-Platform/SigimaX#33).
With a Windows display scaling greater than 100% (e.g. 125%), the splash screen, the welcome page and guided tour logos and the plot watermark were blurry, and most of the text of the user interface kept its 100% size (Qt 5 only).
Changes
scripts/build_resources.pygets a newlogotarget, which renders the images displayed by the application (splash screen, watermark, banners) from their SVG source, together with their@2xhigh-resolution variant (CairoSVG).DataLab-Banner-200.pngandDataLab-Banner2-100.png, which were not generated by the script, are now. The 1x images were regenerated (same appearance; the watermark lost its colored text fringes).guidata.configtools.get_pixmap, which uses the@2xvariants on high-DPI displays; the splash screen and watermark are loaded by SigimaX (Sharp splash screen and watermark on high-DPI displays SigimaX#34).get_pixmapis available in guidatadevelop/master; the minimum guidata version required by DataLab is left unchanged for now and will be raised once guidata is released.Tests
QT_SCALE_FACTOR=1.25: logos are rendered at 438×144 device pixels from the@2xvariant instead of an upscaled 350×115 image.