Repository navigation
Follow Sigima: analysis of non-uniform images, ROIs holding no pixel - #466
Merged
Merged
Conversation
Sigima now gives the analysis results of images with non-uniform coordinates (centroid, enclosing circle, peaks, contours, blobs, Hough circles) in physical coordinates, and refuses to extract regions of interest holding no pixel; the contracts of these operations are at version 2: - the Desktop families reference file is regenerated (centroid and peak_detection recorded in version 2, replayed exactly); the Web file, which records version 1, stays refused until DataLab-Web regenerates it; - ROI > Extract... reports an explicit error for each region of interest holding no pixel (e.g. grid cells narrower than a pixel) and still extracts the others, instead of creating empty images; - release notes and French translations. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows DataLab-Platform/Sigima#110 (same branch name, so CI uses that Sigima branch).
Summary
Sigima now does two things differently:
The contracts of these operations are at version 2.
provenance_desktop_families.h5is regenerated:centroidandpeak_detectionare recorded in version 2 and replayed exactly.provenance_web_families.h5still records version 1 for them. These activities are refused, as checked by the data-driven test, until DataLab-Web regenerates the file.Validation
With the Sigima branch:
common,hdf5): 123 passed;