Repository navigation
Keep contract versions at 1 until a stable application records them - #95
Merged
PierreRaybaut merged 1 commit intoOct 25, 2026
Merged
Conversation
…tracts Contracts are a new feature of Sigima 1.3.0, only used so far by DataLab-Web 0.x, which is not in production; DataLab 1.4, the first stable application recording them, is not released. Version 2 of the eleven contracts whose result changed since 1.3.0 (#88) only refused theoretical recordings, while it made the reference files of DataLab non-replayable. This reverts commit c634bda: those contracts and their qualifications go back to version 1, the changes of Sigima 1.4 being part of it. The decision rule of the guidelines is kept, with the principle that version 1 is settled by the first stable release of an application recording contracts. The image ROI pixel convention recorded in the execution context (#92) is kept: it versions this convention for later changes. Closes #94 Assisted-by: Claude Opus 5.5
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
Reverts #88 (contracts back to version 1, with their qualifications), keeps the decision rule of the guidelines and adds that version 1 is settled by the first stable release of an application recording contracts (DataLab 1.4), with French translation. The breaking-change release note of #88 is removed; the image ROI pixel convention (#92) is kept.
Full suite: 2326 passed;
--qualification-report: no problem, all contracts at version 1.Companion: DataLab provenance tests (same branch name).