Skip to content

Interactive fit dialogs: show the model formula and evaluate models through Sigima #9

Closed

Description

@PierreRaybaut

Context

DataLab 1.3.0 users report that the interactive fit dialogs give no indication of the formula being fitted: the parameter names ("Amplitude", "Scale factor", "Width factor", "Base line" for the Planckian fit) cannot be related to a model without reading sigima/tools/signal/fitting.py.

Problems

  1. No formula in the dialog (enhancement): none of the dialogs created by sigimax.widgets.fitdialog displays the model equation, and parameter labels do not show the symbols used in the documentation (A, x₀, σ, y₀…).
  2. Exponential dialog uses its own model (bug): exponential_fit evaluates a local modelfunc (a * exp(b * x) + c, no clipping) while the stored fit_params are later re-evaluated by sigima.tools.signal.fitting.evaluate_fit, which uses ExponentialFitComputer.evaluate. Both must use the same model.
  3. The Planckian and exponential dialogs inherit the initial guesses and bounds from Sigima, which are being fixed in Planckian and exponential fits depend on data units; Planck signal and domain-based images lack axis information Sigima#74.

Proposed changes

These changes go in the direction of #3 (computation in Sigima as single source of truth, per-type UI presentation) and do not conflict with it.

Related

Activity

  1. added this to the V1.1.0 milestone on Oct 19, 2026
  2. PierreRaybaut commented on Oct 20, 2026

    @PierreRaybaut
    ContributorAuthor

    Fix proposed in DataLab-Platform/Sigima#75, #10 and DataLab-Platform/DataLab#401 (merge order: Sigima, then SigimaX, then DataLab). The PRs target develop, so this issue will not be closed automatically on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions