Skip to content

Follow Sigima: image profiles in physical coordinates #68

Closed

Description

@PierreRaybaut

Sigima now defines image profiles (line, segment, average, radial) in physical coordinates (DataLab-Platform/Sigima#93, DataLab-Platform/Sigima#98): parameters are renamed (row/col → y/x, row1..col2 → x1, y1, x2, y2, x0/y0 → xc/yc) and their contracts move to version 2.

DataLab-Web must follow:

  • ProfileDefinitionDialog converts the drawn shapes to pixel indices and back: it must exchange physical coordinates, placing the shape on the pixel centers used by Sigima;
  • the "Extract" buttons of the image viewer's cross-sections pass row/col to line_profile;
  • tests use the former names, and the cross-edition families reference files record line_profile in contract version 1 (now refused instead of replayed);
  • sigima-dependency.json must point to the Sigima commit providing the change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions